Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make induced_slot recursive #332

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Make induced_slot recursive #332

wants to merge 7 commits into from

Commits on Jul 23, 2024

  1. cache schemaview hash

    @sneakers-the-rat
    sneakers-the-rat committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d0df01b View commit details
    Browse the repository at this point in the history

  2. iterate by ancestor rather than for every slot. check if None rather … 

    …than bool because jsonasobj bool is expensive
    @sneakers-the-rat
    sneakers-the-rat committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    243c4c8 View commit details
    Browse the repository at this point in the history

  3. checkpointing while optimizing induced_slot bc wtf honestly

    @sneakers-the-rat
    sneakers-the-rat committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    138ae4b View commit details
    Browse the repository at this point in the history

  4. this works but also what in tarnation

    @sneakers-the-rat
    sneakers-the-rat committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    631db80 View commit details
    Browse the repository at this point in the history

  5. just create a new object

    @sneakers-the-rat
    sneakers-the-rat committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    657cde3 View commit details
    Browse the repository at this point in the history

  6. or just do our own dict comprehension

    @sneakers-the-rat
    sneakers-the-rat committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c22ca17 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. make induced_slot recursive

    @sneakers-the-rat
    sneakers-the-rat committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f0a7155 View commit details
    Browse the repository at this point in the history