Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: black- and whitelisting #2

Closed
eljefedelrodeodeljefe opened this issue Feb 1, 2017 · 8 comments
Closed

Feature: black- and whitelisting #2

eljefedelrodeodeljefe opened this issue Feb 1, 2017 · 8 comments
Milestone

Comments

@eljefedelrodeodeljefe
Copy link

eljefedelrodeodeljefe commented Feb 1, 2017

...would come in handy. I think chaosmonkey has a similar feature.

@linki
Copy link
Owner

linki commented Feb 1, 2017

Hi @eljefedelrodeodeljefe,

that certainly makes sense. Let's collect a list of what would be useful and not too complicated to use and implement.

I can think of

  • white- and blacklisting by namespace(s)
  • white- and blacklisting by label selector

blacklisting trumps whitelisting, I guess. So pods matching a whitelisted label selector that are in a blacklisted namespace should not be killed.

@eljefedelrodeodeljefe
Copy link
Author

I think that concludes it to be lightweight. Sounds good to me.

@kfox1111
Copy link

kfox1111 commented Feb 6, 2017

Another possibility is attributes.

@linki
Copy link
Owner

linki commented Feb 7, 2017

@kfox1111 want do you have in mind?

something like this maybe:

  • all pods with some value for an attribute (e.g. serviceAccountName=default)
  • all pods containing at least one container with some value for an attribute (e.g. image=nginx )

@linki
Copy link
Owner

linki commented Feb 7, 2017

@eljefedelrodeodeljefe @kfox1111 Label based solution is here: #5. Let me know what you think.

@linki
Copy link
Owner

linki commented Feb 11, 2017

@eljefedelrodeodeljefe Namespace-based filtering, both white- and blacklisting supported, no regexp shenanigans: #9 (comment)

@linki
Copy link
Owner

linki commented Feb 12, 2017

Label-based and namespace-based selection is part of the v0.4.0 release

I'm going to close this and create a new issue for attribute based filtering: #12

@linki linki closed this as completed Feb 12, 2017
@linki
Copy link
Owner

linki commented Feb 12, 2017

thanks @eljefedelrodeodeljefe and @kfox1111 for the suggestions!

@linki linki added this to the v0.4 milestone Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants