-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s event to the resource owning the pod(s) being terminated. #155
Comments
Hi @pims, that sounds very useful to me. What about duplicated events in this case? When I'm doing |
I need to do some more research on how other project implement this kind of functionality. My guess is that most of the complexity comes from navigating the tree of owners. |
Sounds good! |
After prototyping a solution to this, I am no longer convinced this is a good idea. One alternative would be to add annotations on the pod itself that points to any resource that should be notified. |
Do you mean that in order to reach a Pod's Deployment you have to read the owning ReplicaSet to get its owner? How about adding the event only on the direct owner for now? |
Yes, which requires doing a Get on the parent and possibly on the parent's parent.
That'd be easier, but in the case of a Deployment, I'm not sure how useful it is to add an event to the ReplicaSet controlling the current deployment. What do you think? |
Hi @linki,
Thoughts on also adding the termination event to the top most owner of a pod in addition to the pod itself?
We're attempting to add visibility for application owners when their pods get terminated – and new pods are starting. The terminated pods kind of disappear from the current view of the deployment, which adds a bit of work to find if any pod has been terminated through ChaosKube.
I know that it's possible to look at events in that namespace to find out what happened, but I believe that adding an event to the deployment/parent of the pod would greatly help in surfacing the actions of ChaosKube.
If that sounds like a useful feature, I'll happily submit a PR.
The text was updated successfully, but these errors were encountered: