From f9194e84097170362ba0eed5564f2a54964dbbcf Mon Sep 17 00:00:00 2001
From: Andrew Choi <li_andchoi@microsoft.com>
Date: Wed, 14 Oct 2020 03:54:24 -0700
Subject: [PATCH] Xinfra Monitor MultiClusterTopicManagementService Exception
 Signature Changes (#318)

Xinfra Monitor MultiClusterTopicManagementService: InterruptedException, ExecutionException, TimeoutException
`Signed-off-by: Andrew Choi <li_andchoi@microsoft.com>`
---
 .../services/MultiClusterTopicManagementService.java      | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java b/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java
index d024ebf6..25a12759 100644
--- a/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java
+++ b/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java
@@ -15,11 +15,9 @@
 import com.linkedin.xinfra.monitor.services.configs.MultiClusterTopicManagementServiceConfig;
 import com.linkedin.xinfra.monitor.services.configs.TopicManagementServiceConfig;
 import com.linkedin.xinfra.monitor.topicfactory.TopicFactory;
-import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
-import kafka.admin.AdminUtils;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -35,6 +33,7 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicBoolean;
+import kafka.admin.AdminUtils;
 import kafka.admin.BrokerMetadata;
 import org.apache.kafka.clients.admin.AdminClient;
 import org.apache.kafka.clients.admin.AdminClientConfig;
@@ -219,7 +218,7 @@ public void run() {
           TopicManagementHelper helper = entry.getValue();
           try {
             helper.maybeElectLeader();
-          } catch (IOException | KafkaException e) {
+          } catch (KafkaException e) {
             LOGGER.warn(_serviceName + "/MultiClusterTopicManagementService will retry later in cluster " + clusterName,
                 e);
           }
@@ -435,6 +434,7 @@ void maybeReassignPartitionAndElectLeader() throws ExecutionException, Interrupt
 
       if (expectedReplicationFactor > currentReplicationFactor && Utils.ongoingPartitionReassignments(_adminClient)
           .isEmpty()) {
+
         LOGGER.info(
             "MultiClusterTopicManagementService will increase the replication factor of the topic {} in cluster"
                 + "from {} to {}", _topic, currentReplicationFactor, expectedReplicationFactor);
@@ -482,7 +482,7 @@ void maybeReassignPartitionAndElectLeader() throws ExecutionException, Interrupt
       }
     }
 
-    void maybeElectLeader() throws Exception {
+    void maybeElectLeader() throws InterruptedException, ExecutionException, TimeoutException {
       if (!_preferredLeaderElectionRequested) {
         return;
       }