You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should document the Go to Definition functionality so that a user knows what is provided in which type of workspace. Some context to start with is below.
The extension should already detect if the folder opened is part of a control repository, so you shouldn't need to add
The rules to detect are:
You must be opening a Folder (aka workspace) in VSCode, not a single file
You must be opening a Folder either at the root of, or inside of, the control repo. Not outside of it.
The control repo must contain an environment.conf
The control repo must NOT contain a metadata,json file. If you have both, the extension will assume it's inside a module (not a control repo)
Now there are some cases where using that setting is needed. For example, I know that @genebean has a folder containing all of the download modules from Onceover, and he needs to add the Onceover path to get the intellisense.
We should document the
Go to Definition
functionality so that a user knows what is provided in which type of workspace. Some context to start with is below.The extension should already detect if the folder opened is part of a control repository, so you shouldn't need to add
The rules to detect are:
environment.conf
metadata,json
file. If you have both, the extension will assume it's inside a module (not a control repo)Now there are some cases where using that setting is needed. For example, I know that @genebean has a folder containing all of the download modules from Onceover, and he needs to add the Onceover path to get the intellisense.
Some code references:
https://github.com/puppetlabs/puppet-editor-services/blob/master/lib/puppet-languageserver/document_store.rb#L105-L132
https://github.com/puppetlabs/puppet-editor-services/blob/master/spec/languageserver-sidecar/integration/puppet-languageserver-sidecar/puppet-languageserver-sidecar_spec.rb#L226-L249
Originally posted by @glennsarti in puppetlabs/puppet-vscode#636 (comment)
The text was updated successfully, but these errors were encountered: