Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate magic constants from the protocol. #2701

Open
MathieuDutSik opened this issue Oct 23, 2024 · 0 comments
Open

Eliminate magic constants from the protocol. #2701

MathieuDutSik opened this issue Oct 23, 2024 · 0 comments
Labels
low priority

Comments

@MathieuDutSik
Copy link
Contributor

Currently, we have in the protocol, Duration::from_secs(3) / Duration::from_millis(250) in get_chain_worker_endpoint. While this does not cause any issues, it is not great to have hard coded constants in the code. It should be part of a configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MathieuDutSik