Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trying validators in random order, take weights into account. #2616

Open
afck opened this issue Oct 14, 2024 · 2 comments
Open

When trying validators in random order, take weights into account. #2616

afck opened this issue Oct 14, 2024 · 2 comments
Milestone

Comments

@afck
Copy link
Contributor

afck commented Oct 14, 2024

If a validator has five times less weight its misbehavior should do five times less harm. So whenever we try to obtain something sequentially from the different validators, in order, we should not just shuffle the vector: the validators should be picked with a probability proportional to their weights. That way, a validator with very little stake can only cause very few delays.

@afck afck added this to the Testnet #2 milestone Oct 14, 2024
@deuszx
Copy link
Contributor

deuszx commented Oct 14, 2024

This also means that a validator with five times the stake can cause five times the censorship, doesn't it?

@afck
Copy link
Contributor Author

afck commented Oct 14, 2024

In those places where we do that (search shuffle in local_node.rs) we only download things that we immediately verify. So the first validator in line can't censor anything there, they can just refuse to answer and thereby cause a delay until we ask the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants