Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Env and Data #373

Closed
PoignardAzur opened this issue Dec 23, 2022 · 3 comments
Closed

Remove Env and Data #373

PoignardAzur opened this issue Dec 23, 2022 · 3 comments
Labels
masonry Issues relating to the Masonry widget layer

Comments

@PoignardAzur
Copy link
Contributor

The Env class and the Data trait are vestigial by this point in the Masonry codebase.

There is currently no support for updating widgets when the Env is changed, and I have no intention of adding that support (Xilem seems to be moving in the same direction). This means Env is basically just a way to pass a singleton around in Widget code.

We should remove Env and data, and just hardcode the values that we currently get from Env, with future plans to pass them as arguments or something. Frontend frameworks might still use something Env-like to get style data, but that'll be their responsibility.

@herkhinah
Copy link

I've refactored both of them out in linebender/masonry#53

@DJMcNab DJMcNab added the masonry Issues relating to the Masonry widget layer label Apr 19, 2024
@DasLixou
Copy link

@PoignardAzur i think this can be closed because of linebender/masonry#54 ?

@PoignardAzur
Copy link
Contributor Author

Yup. I should probably do a cleanup run over issues before we migrate them to Xilem.

@DJMcNab DJMcNab transferred this issue from linebender/masonry Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
masonry Issues relating to the Masonry widget layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants