-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode alpha for Images #692
Labels
help wanted
Extra attention is needed
Comments
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 20, 2024
This updates Peniko to [0.2.0](https://github.com/linebender/peniko/releases/tag/v0.2.0). The main impact this would have on users is being able to set `alpha` on images, but that is currently broken because of #692. This also updates to Kurbo [0.11.1](https://github.com/linebender/kurbo/releases/tag/v0.11.1), which of note includes linebender/kurbo#353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, when encoding an image, the alpha factor is discarded:
vello/vello_encoding/src/encoding.rs
Lines 420 to 424 in 4433203
The consequences of this are:
with_alpha_factor
tomultiply_alpha
peniko#52To fix this, we need to wire this alpha through to
fine
(because of #664 and friends), somehow.The text was updated successfully, but these errors were encountered: