Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework gradient support to match Peniko #6

Open
waywardmonkeys opened this issue Aug 17, 2024 · 1 comment
Open

Rework gradient support to match Peniko #6

waywardmonkeys opened this issue Aug 17, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@waywardmonkeys
Copy link
Collaborator

Peniko has an additional gradient kind that isn't supported here.

We should grow to match Peniko: https://github.com/linebender/peniko/blob/3d040a9d4f309c2dbefbd96b64bfb0cc629fec33/src/gradient.rs#L61-L93
@waywardmonkeys waywardmonkeys added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 17, 2024
@waywardmonkeys waywardmonkeys mentioned this issue Aug 17, 2024
Merged
@simbleau
Copy link
Member

This is great actually, because Lottie has sweep gradients we never supported :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waywardmonkeys @simbleau