Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical SLDS not implemented #108

Open
bagibence opened this issue Jun 25, 2020 · 3 comments
Open

Hierarchical SLDS not implemented #108

bagibence opened this issue Jun 25, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@bagibence
Copy link
Contributor

Hi! I just noticed that the SLDS class doesn't seem to support hierarchical parameters anymore. Is this on purpose?
If yes, I think __init__ taking the arguments hierarchical_transition_tags, hierarchical_dynamics_tags, hierarchical_emission_tags is a bit misleading and could be removed. I thought I was fitting a hierarchical model by specifying them but then saw that they're not actually used.
If not, could this functionality be restored by borrowing code from HMM.__init__ or would it be much more complex than that?

@bantin
Copy link
Collaborator

bantin commented Jun 29, 2020

Hi @bagibence, thanks for pointing this out. We're not really supporting hierarchical LDS and SLDS at the moment, and should strip out those arguments. I think implementing them in a way that is reasonably well-performing (in terms of speed) would be fairly involved, since it would likely require writing custom M-steps. For now, I'm going to take out those arguments so things aren't so confusing!

@bantin
Copy link
Collaborator

bantin commented Jun 29, 2020

Removed unused args in e487a65. Moving to "enhancement" since this would be a nice feature.

@bantin bantin added the enhancement New feature or request label Jun 29, 2020
@robinvloeberghs
Copy link

Hello! Is there any follow-up on this topic? I'm currently working with a LDS that has Bernoulli emissions and AR dynamics and I'm very interested to implement a hierarchical extension for both levels. I found some code in one of the branches for a hierarchical AR: https://github.com/lindermanlab/ssm/blob/e97ea4f0904cd204f392c2cfc4528ef860d71f9d/ssm/hierarchical.py

Is it possible to apply the same structure to implement a hierarchical version for Bernoulli emissions? Or does this require additional custom code for eg the M-steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants