Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psutil is unpinned #78

Open
nitrocode opened this issue Jul 30, 2024 · 1 comment
Open

psutil is unpinned #78

nitrocode opened this issue Jul 30, 2024 · 1 comment

Comments

@nitrocode
Copy link
Contributor

I noticed that the only dependency this cli tool has is psutil and it's not currently pinned to a version because it's defined here instead of in a requirements.txt (which is separate from the dev version of that I believe).

install_requires=["psutil"],

In homebrew, its defined at the time of the last build which was 5.9.8

https://github.com/Homebrew/homebrew-core/blob/37fc6c59bd980bc309f0a78549afc7238b1ef855/Formula/a/aws2-wrap.rb#L23-26

Now there is a new major release of psutils 6.0.0 which might have breaking changes.

https://pypi.org/project/psutil/#history

We can avoid a broken build by pinning and keep builds of aws2-wrap deterministic.

@pcolmer
Copy link
Contributor

pcolmer commented Aug 1, 2024

@nitrocode I'm not seeing anything in https://github.com/giampaolo/psutil/blob/master/HISTORY.rst that suggests the small use I'm making of it is affected by the major release, but I take your point.

Feel free to submit your preferred solution to this.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants