Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA 1352 new files appear in offline mode #967

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

KhaledNjim
Copy link
Collaborator

Gitlab Ticket

Root cause

  • When saving received shares in the local database, the recipient's information is not tracked. As a result, when retrieving all received shares, documents that were saved by other users on the same device are mistakenly included in the received shares list.
  • When a received share is deleted or expires, it still remains present in the local database, leading to the display of unavailable documents in the received shares list in offline mode

Solution

  • Added recipient information when saving received shares to the local database when data is retrieved.
  • Added test for expiration date while retrieving
  • Implemented an interactor to remove received shares from the local database when they are no longer available (deleted or expired)

Demo

1352.webm

Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

@KhaledNjim KhaledNjim force-pushed the LA-1352_new_files_appear_in_offline_mode branch from 98800cf to 7bd656d Compare November 14, 2024 23:55
@hoangdat hoangdat merged commit 15a4665 into master Nov 15, 2024
4 checks passed
@hoangdat hoangdat deleted the LA-1352_new_files_appear_in_offline_mode branch November 15, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants