Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Fixed wrong create workspace button text translation key (#1217) #945

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

KhaledNjim
Copy link
Collaborator

@KhaledNjim KhaledNjim commented Feb 22, 2024

Description

GitLab issue

updated the create workspace button translation key, from create_workspace to create_new_workspace

before

image

after

after

@hoangdat
Copy link
Member

please add screenshot or video demo. Thank you

@KhaledNjim KhaledNjim changed the title Changed text from create workspace to create new workspace 🐛 Fix: Fixed wrong create workspace button text translation key (#1217) Feb 23, 2024
@KhaledNjim KhaledNjim force-pushed the bugFix/missing_text_in_create_workgroup branch 2 times, most recently from 60b2932 to dea973c Compare February 23, 2024 10:10
@KhaledNjim
Copy link
Collaborator Author

@hoangdat done

@hoangdat
Copy link
Member

hoangdat commented Feb 23, 2024

dont bump version here, will do it in separated PR. Please update the commit message to follow the template
LA-{ticketId} {Message content}

@KhaledNjim KhaledNjim force-pushed the bugFix/missing_text_in_create_workgroup branch from dea973c to 63d98de Compare February 23, 2024 12:19
@KhaledNjim
Copy link
Collaborator Author

dont bump version here, will do it in separated PR. Please update the commit message to follow the template LA-{ticketId} {Message content}

should be ok now.

@hoangdat hoangdat merged commit 9aa14b8 into master Feb 27, 2024
4 checks passed
@hoangdat hoangdat deleted the bugFix/missing_text_in_create_workgroup branch February 27, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants