Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect expiration date for files in mySpace #943

Closed
wants to merge 1 commit into from
Closed

Fixed incorrect expiration date for files in mySpace #943

wants to merge 1 commit into from

Conversation

KhaledNjim
Copy link
Collaborator

@KhaledNjim KhaledNjim commented Feb 21, 2024 •
edited
Loading

Description

GitLab issue

Root cause

  • Wrong Key for expiration date in document_details
  • The expiration date doesn't take into consideration undefined expiration date

Solution

  • Called the right expiration date key in document_details
  • Added handling for null expiration_date

hoangdat
hoangdat reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srr, but it also include too much format change. hard for me.

@KhaledNjim KhaledNjim closed this Feb 26, 2024
@KhaledNjim KhaledNjim deleted the bugFix/#1220_incorrect_file_expiration_date_in_myspace branch February 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhaledNjim @hoangdat