Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractDoctrineLoader breaks CmfMediaBundle compatibility #375

Closed
awdng opened this issue Mar 31, 2014 · 5 comments
Closed

AbstractDoctrineLoader breaks CmfMediaBundle compatibility #375

awdng opened this issue Mar 31, 2014 · 5 comments
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality.

Comments

@awdng
Copy link

awdng commented Mar 31, 2014

The new constructor signature found here:
https://github.com/liip/LiipImagineBundle/commits/81ba74c34c12e75327e21e6266082b870a349543/Imagine/Data/Loader/AbstractDoctrineLoader.php

does not play well with:
https://github.com/symfony-cmf/MediaBundle/blob/master/Adapter/LiipImagine/CmfMediaDoctrineLoader.php

Also there is an undefined variable called $formats in the constructor now
@makasim
Copy link
Collaborator

makasim commented Mar 31, 2014

formats has to be removed.

@makasim
Copy link
Collaborator

makasim commented Mar 31, 2014

CmfMediaBundle has requirmenrs ~0.12 which allows 1.0 as I can see. @dbu it has to be set ~0.12,<1.0. While raising required version of liip imagine bundle in media bundle the loader has to be adjusted and tested.

@makasim
Copy link
Collaborator

makasim commented Apr 1, 2014

formats removed in a1cb294

@makasim makasim added this to the v1.1 milestone May 22, 2014
@makasim makasim added the Bug label May 22, 2014
@makasim
Copy link
Collaborator

makasim commented May 30, 2014

@dbu you can migrate cmf media bundle. Liip imagine bundle is table and no more BC breaks in 1.0.

@dbu dbu mentioned this issue Jun 4, 2014
Merged
2 tasks
@lsmith77
Copy link
Contributor

closing in favor of symfony-cmf/media-bundle#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@makasim @lsmith77 @awdng