Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate with the CMF routing component #219

Closed
lsmith77 opened this issue Aug 12, 2013 · 7 comments
Closed

integrate with the CMF routing component #219

lsmith77 opened this issue Aug 12, 2013 · 7 comments
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Milestone

Comments

@lsmith77
Copy link
Contributor

This is just a thought but it might be cool to integrate this Bundle (optionally) with the CMF routing component (http://symfony.com/doc/master/cmf/components/routing/index.html) and the RoutingBundle. Then again there might be little benefit so I am not sure if its worth it.

The idea being that we implement a RouteProvider that does the dynamic lookups rather than doing that in the controller.

@dbu
Copy link
Member

dbu commented Dec 3, 2013

how do you want to integrate this with the routing, what would be the goal?

@havvg
Copy link
Contributor

havvg commented Dec 13, 2013

The URL in the description is not available anymore.

@lsmith77
Copy link
Contributor Author

i have updated the link

@dbu
Copy link
Member

dbu commented Dec 15, 2013

@lsmith77 can you elaborate what you mean? its not obvious to me what you want to integrate. obviously with #277 we somehow touch the subject of content negotiation but that would be another story. having different controllers for different imagine filters seems strange to me. at that point you would probably simply build your own thing and maybe use imagine in your custom controllers. if anything, a filter provider could be a service rather than configuration of filters, if that is not already possible.

@lsmith77
Copy link
Contributor Author

added a note in description

@dbu
Copy link
Member

dbu commented Dec 16, 2013

ah, ok. we could use a DynamicRouter instance with a route provider that looks into the filesystem and generates routes. this would potentially be a huge numer of routes, as it is number of filters * number of files. and i am not sure what it would help us. you could have different controllers per filter or based on some logic with a route enhancer, but i don't really see a use case for that. in terms of performance it won't gain us anything i fear, rather cost as we hook another router into the chain router.
i don't see any relevant benefit from it. its adding another dependency without adding useful new features afaict.

@makasim
Copy link
Collaborator

makasim commented May 22, 2014

Custom route loader was removed and I dont see the need of cmf routing here. Feel free to reopen if it usefull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants