-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate with the CMF routing component #219
Comments
how do you want to integrate this with the routing, what would be the goal? |
The URL in the description is not available anymore. |
i have updated the link |
@lsmith77 can you elaborate what you mean? its not obvious to me what you want to integrate. obviously with #277 we somehow touch the subject of content negotiation but that would be another story. having different controllers for different imagine filters seems strange to me. at that point you would probably simply build your own thing and maybe use imagine in your custom controllers. if anything, a filter provider could be a service rather than configuration of filters, if that is not already possible. |
added a note in description |
ah, ok. we could use a DynamicRouter instance with a route provider that looks into the filesystem and generates routes. this would potentially be a huge numer of routes, as it is number of filters * number of files. and i am not sure what it would help us. you could have different controllers per filter or based on some logic with a route enhancer, but i don't really see a use case for that. in terms of performance it won't gain us anything i fear, rather cost as we hook another router into the chain router. |
Custom route loader was removed and I dont see the need of cmf routing here. Feel free to reopen if it usefull. |
This is just a thought but it might be cool to integrate this Bundle (optionally) with the CMF routing component (http://symfony.com/doc/master/cmf/components/routing/index.html) and the RoutingBundle. Then again there might be little benefit so I am not sure if its worth it.
The idea being that we implement a RouteProvider that does the dynamic lookups rather than doing that in the controller.
The text was updated successfully, but these errors were encountered: