Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip: export new inbound fee related gauges #107

Open
Roasbeef opened this issue Jun 3, 2024 · 1 comment · May be fixed by #113
Open

gossip: export new inbound fee related gauges #107

Roasbeef opened this issue Jun 3, 2024 · 1 comment · May be fixed by #113
Assignees

Comments

@Roasbeef
Copy link
Member

Roasbeef commented Jun 3, 2024

With the release of lnd v0.18.0 we have a new piece of data to export/graph/analyze: inbound fee discounts.

We should export two new gauges so we can track the uptake of this new feature on the network:

  • A gauge for the total amount of channel updates that set the inbound fee to a non-zero value.
    • We can also check the code check for existence of the new TLV as well, so even those that have upgraded, but set it to zero would contribute to this metric.
  • A histogram for the various values of the inbound fee discount. We can use this to create percentile graphs and heatmaps, etc.
@levmi
Copy link

levmi commented Jun 3, 2024

It would also be cool to add this to rankings down the line in some way potentially cc @bitromortac @jbrill @dstrukt

@bitromortac bitromortac self-assigned this Oct 17, 2024
@bitromortac bitromortac linked a pull request Oct 28, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants