Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal allows creating loop with a transaction that has a too low feerate #700

Open
mrfelton opened this issue Dec 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mrfelton
Copy link

mrfelton commented Dec 23, 2023

I used terminal to do a loop in. The onchain transaction was created with a super low fee (7.5 sat/vB at a time when next block rate was ~400 and most nodes were purging / not relaying transactions under 20 sat/vB). As a result the transaction never made it into the mempool.

Expected behavior

The terminal UI shouldn't allow me to use a confirmation target where the resulting fee rate would be so low that the transaction would not get relayed.

Actual behavior

I was able to initiate a loop in with a transaction that didn't get relayed.

To reproduce

Use terminal to do a loop in and set the conf target far into the future such that the resulting fee rate would be below the current min feerate.

System information

Running latest version of terminal standalone, using terminal web.

@mrfelton mrfelton added the bug Something isn't working label Dec 23, 2023
@mrfelton mrfelton changed the title loop in transaction broadcast with too low feerate terminal allows broadcasting loop in transaction with too low feerate Dec 23, 2023
@mrfelton mrfelton changed the title terminal allows broadcasting loop in transaction with too low feerate Terminal allows creating loop with a transaction that has a too low feerate Dec 23, 2023
@levmi
Copy link
Contributor

levmi commented Jan 3, 2024

Hiya- thanks for the report! Did you explicitly set a high confirmation target in the UI? What would your expectation be with regard to how the UI responds to that custom input? Essentially, you'd want the UI to provide context that the selected confirmation target would result in a sats/vbyte that wouldn't get relayed I assume? :)

@mrfelton
Copy link
Author

mrfelton commented Jan 9, 2024

Did you explicitly set a high confirmation target in the UI?

I did.

What would your expectation be with regard to how the UI responds to that custom input? Essentially, you'd want the UI to provide context that the selected confirmation target would result in a sats/vbyte that wouldn't get relayed I assume? :)

Yeah, I think it should compare the fee rate of the selected conf target with the min relay rate and either provide a warning advising against, or outright preventing the user from being able to submit with a conf target that will result in a transaction that won't get relayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants