Skip to content

Commit

Permalink
gbn: increase NACK wait time by 2X
Browse files Browse the repository at this point in the history
  • Loading branch information
ViktorTigerstrom committed Nov 13, 2023
1 parent 64f45c2 commit 8f8ecc9
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions gbn/gbn_conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,18 @@ func (g *GoBackNConn) receivePacketsForever() error { // nolint:gocyclo

// If we recently sent a NACK for the same
// sequence number then back off.
if lastNackSeq == g.recvSeq &&
time.Since(lastNackTime) < g.resendTimeout {
// We wait 2 times the resendTimeout before
// sending a new nack, as this case is likely
// hit if the sender is currently resending
// the queue, and therefore the threads that
// are resending the queue is likely busy with
// the resend, and therefore won't react to the
// NACK we send here in time.
sinceSent := time.Since(lastNackTime)
recentlySent := sinceSent < g.resendTimeout*2 //nolint:gomnd

if lastNackSeq == g.recvSeq && recentlySent {
log.Tracef("Recently sent NACK")

continue
}
Expand Down

0 comments on commit 8f8ecc9

Please sign in to comment.