Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prevtx in TxAddInput message an Option #2869

Closed
dunxen opened this issue Feb 2, 2024 · 2 comments
Closed

Make prevtx in TxAddInput message an Option #2869

dunxen opened this issue Feb 2, 2024 · 2 comments

Comments

@dunxen
Copy link
Contributor

dunxen commented Feb 2, 2024

It looks like there are cases where prevtx can be omitted.
See recent spec meeting notes here: lightning/bolts#1129 (comment) and the linked Delving Bitcoin post by t-bast, specifically:

That means that for lightning, we should only drop the prevtx field if:

  • this is a splice transaction of a taproot channel (there is a shared input that uses taproot and requires signatures from both participants)
  • or each participant adds at least one taproot input to the transaction
@wpaulino
Copy link
Contributor

wpaulino commented Feb 5, 2024

Looks like this is being pushed back for now: niftynei/lightning-rfc#18 (comment)

@dunxen
Copy link
Contributor Author

dunxen commented Feb 6, 2024

Looks like this is being pushed back for now

Thanks. It makes sense to close this as the comment you linked to imply additional work beyond the original suggestion.

@dunxen dunxen closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants