Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc bug #1086

Open
rstento opened this issue Aug 12, 2021 · 2 comments
Open

Minor doc bug #1086

rstento opened this issue Aug 12, 2021 · 2 comments
Assignees

Comments

@rstento
Copy link
Contributor

rstento commented Aug 12, 2021

Reported by a partner -- On this page: https://developer.lightbend.com/docs/cloudflow/current/develop/akka-streamlet-utilities.html

In this list:
HttpServerLogic

HttpServerLogic

Splitter

Merger

The second HttpServerLogic should be GrpcServerLogic.

The source file in this repo is: https://github.com/lightbend/cloudflow/blob/main/docs/shared-content-source/docs/modules/develop/pages/akka-streamlet-utilities.adoc

But, it is also shared in the Enterprise docs, so once the fix is merged, the Enterprise doc should be published so it picks up the change. https://github.com/lightbend/cloudflow-enterprise-docs

thothmoses added a commit that referenced this issue Aug 12, 2021
per
Minor doc bug #1086
@thothmoses
Copy link
Contributor

@rstento The first part is complete. I have tried to do the second part but I must be missing a step because I can't seem to get the content pulled into the enterprise docs.

@rstento
Copy link
Contributor Author

rstento commented Aug 12, 2021

@rstento The first part is complete. I have tried to do the second part but I must be missing a step because I can't seem to get the content pulled into the enterprise docs.

Thanks @thothmoses! I'll have to take a look at this tomorrow. I don't remember how the docs are connected since I haven't worked with them in a while. I know it was done differently than the Akka Serverless docs. I was hoping that it would be as simple as making an unrelated change in the enterprise docs, add or remove a comma, or something similar, and the merge to that PR should automatically pull the latest from the cloudflow.io docs (if the PR has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants