Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UID codeblocks refactor #396

Merged
merged 15 commits into from
Oct 12, 2023
Merged

UID codeblocks refactor #396

merged 15 commits into from
Oct 12, 2023

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Sep 29, 2023

No description provided.

@ekilmer
Use UID for codeblocks
9d933b8
@ekilmer
Merge branch 'patchable-ir-main' into ekilmer/uid-codeblocks
d27b985 
* patchable-ir-main:
  Revert "Debug utils (#369)" (#391)
  Ian/allow for typehints in spec (#390)
  Use encoded type for constant value mappings (#388)
  Remove challenge testing (#389)
  Debug utils (#369)
  Add `-j` flag to `test-amp-challenge-bins.sh` and update ignore list (#380)
@ekilmer
Fix BasicBlockContext lookups
6daea19 
Fixes the missing literal_struct_2 issue
@ekilmer
Test CI
4cfe2d9
@ekilmer
Strong Uid typing
b738508
@ekilmer
Cleanup and support parsing Json spec
9a97fa9
@ekilmer
Revert "Test CI"
e717d07 
This reverts commit 4cfe2d9.
@ekilmer
Remove basic block address metadata
2095521 
Look up address using UID
@ekilmer
Merge branch 'patchable-ir-main' into ekilmer/uid-codeblocks
735d348 
* patchable-ir-main:
  Support lifting x87 80-bit float constants (#393)
  Bump `lifting-tools-ci` (#394)
@ekilmer ekilmer marked this pull request as ready for review October 3, 2023 17:07
@ekilmer ekilmer requested a review from 2over12 October 3, 2023 17:08
2over12
2over12 requested changes Oct 4, 2023
View reviewed changes
lib/Lifters/BasicBlockLifter.cpp Outdated Show resolved Hide resolved
lib/Lifters/FunctionLifter.cpp Outdated Show resolved Hide resolved
lib/Lifters/FunctionLifter.cpp Outdated Show resolved Hide resolved
@ekilmer ekilmer requested a review from 2over12 October 6, 2023 15:32
@ekilmer
Keep track of UID to CodeBlock mapping
cadd2d9 
Useful for getting CodeBlock function addresses without a tracked
function
@ekilmer
Merge branch 'patchable-ir-main' into ekilmer/uid-codeblocks
a95ee40 
* patchable-ir-main:
  Callsite override (#398)
@ekilmer
Merge branch 'patchable-ir-main' into ekilmer/uid-codeblocks
cf7798c 
* patchable-ir-main:
  check if index is in range (#397)
2over12
2over12 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@2over12 2over12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@2over12 2over12 merged commit 610205a into patchable-ir-main Oct 12, 2023
7 checks passed
@ekilmer ekilmer deleted the ekilmer/uid-codeblocks branch October 25, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2over12 2over12 2over12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekilmer @2over12