Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract interface into a separate crate #81

Closed
nagisa opened this issue Apr 5, 2015 · 0 comments
Closed

Extract interface into a separate crate #81

nagisa opened this issue Apr 5, 2015 · 0 comments
Assignees
@lifthrasiir
Milestone
0.3

Comments

@nagisa
Copy link
Contributor

nagisa commented Apr 5, 2015

Some (e.g. me) might want to use encoding’s interfaces and build decoders and encoders for their own encodings (e.g. see #68). Pulling in the whole encoding with all its supported encodings and their tables is not quite ergonomic, though, and splitting interfaces/types/traits out from the main crate would keep encoding as simple to use as it is currently and allow people to build on it.
@lifthrasiir lifthrasiir added this to the 0.3 milestone Apr 5, 2015
@lifthrasiir lifthrasiir self-assigned this Apr 5, 2015
nagisa added a commit to nagisa/rust-encoding that referenced this issue Jul 19, 2015
@nagisa
Split encoding::types into encoding-types crate
13901cd 
This allows for creation of alternative non-WHATWG encodings that use the same
interface as encodings defined in this crate without pulling in all the
tables and encodings.

This commit does not introduce any breaking changes; all the types previously defined in
encoding::types are reexported.

Fixes lifthrasiir#81.
@nagisa nagisa mentioned this issue Jul 19, 2015
Merged
nagisa added a commit to nagisa/rust-encoding that referenced this issue Jul 20, 2015
@nagisa
Split encoding::types into encoding-types crate
64d05c0 
This allows for creation of alternative non-WHATWG encodings that use the same
interface as encodings defined in this crate without pulling in all the
tables and encodings.

This commit does not introduce any breaking changes; all the types previously defined in
encoding::types are reexported.

Fixes lifthrasiir#81.
nagisa added a commit to nagisa/rust-encoding that referenced this issue Jul 20, 2015
@nagisa
Split encoding::types into encoding-types crate
280564a 
This allows for creation of alternative non-WHATWG encodings that use the same
interface as encodings defined in this crate without pulling in all the
tables and encodings.

This commit does not introduce any breaking changes; all the types previously defined in
encoding::types are reexported.

Fixes lifthrasiir#81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifthrasiir lifthrasiir

Labels
None yet
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
2 participants
@lifthrasiir @nagisa