Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the Tabs component and implement improvements #5171

Closed
matuzalemsteles opened this issue Nov 3, 2022 · 1 comment · Fixed by #5175
Closed

Review the Tabs component and implement improvements #5171

matuzalemsteles opened this issue Nov 3, 2022 · 1 comment · Fixed by #5175
Assignees
@matuzalemsteles
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code
Milestone
LPS-166807 Weekly...

Comments

@matuzalemsteles
Copy link
Member

Before implementing the Collection pattern to Tabs, we need to review the component composition, recently we made some improvements like handling the OOTB state to improve the accessibility of component #5151 but it was not better yet for some scenarios because the component composition prevents us. Some points to review:

  • Composition of tabs and panel are siblings rather than children of a parent component. This makes it difficult to control state and provide more OOTB stuff.
  • Remove the need for the developer to manually add aria-controls and id to bind the tab with the panel
@matuzalemsteles matuzalemsteles added type: enhancement Issues that are open to bring improvements or refinement of code comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Nov 3, 2022
@matuzalemsteles matuzalemsteles mentioned this issue Nov 3, 2022
Open
@matuzalemsteles matuzalemsteles self-assigned this Nov 3, 2022
@matuzalemsteles matuzalemsteles mentioned this issue Nov 4, 2022
Merged
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-166807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
LPS-166807 Weekly Clay release Novemb...
Development

Successfully merging a pull request may close this issue.

feat(@clayui/tabs): adds new compositing pattern matuzalemsteles/clay
1 participant
@matuzalemsteles