Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players in the Lobby/Correspondence lists are not rendered with fullName #16446

Closed
Siderite opened this issue Nov 20, 2024 · 5 comments
Closed

Comments

@Siderite
Copy link

Exact URL of where the bug happened

https://lichess.org/

Steps to reproduce the bug

  1. go to the main page
  2. click on Lobby or Correspondence tabs

What did you expect to happen?

users should be shown with title and/or flair (

export const fullName = (u: AnyUser): MaybeVNode[] => [userTitle(u), u.name, userFlair(u)];
)

What happened instead?

instead only the username is shown with the old ulink class rather than user-link, which seems to only be used here.

Operating system

Windows 11

Browser and version (or alternate access method)

Brave

Additional information

No response

@Siderite Siderite added the bug label Nov 20, 2024
@cmgchess
Copy link
Contributor

even in lichess/tv flairs are not shown

@SergioGlorias SergioGlorias removed the bug label Nov 20, 2024
@SergioGlorias
Copy link
Contributor

SergioGlorias commented Nov 20, 2024

I'd rather not load flairs in unstable places

@Siderite
Copy link
Author

The user actually wanted the titles of the players, not the flairs.

@SergioGlorias
Copy link
Contributor

ok checking the code, it seems the title is not provided
just the username

export interface Hook {
id: string;
sri: string;
clock: string;
t: number; // time
s: number; // speed
i: number; // increment
variant: VariantKey;
perf: Exclude<Perf, 'fromPosition'>;
prov?: true; // is rating provisional
u?: string; // username
rating?: number;
ra?: 1; // rated
action: 'cancel' | 'join';
disabled?: boolean;
}
export interface Seek {
id: string;
username: string;
rating: number;
mode: number;
days?: number;
perf: {
key: Exclude<Perf, 'fromPosition'>;
};
provisional?: boolean;
variant?: { key: VariantKey };
action: 'joinSeek' | 'cancelSeek';
}

@ornicar
Copy link
Collaborator

ornicar commented Nov 23, 2024

I don't think it's a good idea. It puts a target on their back, making them more likely to be snipped by the many players who (for various reasons, some related to cheating) seek to play rated players.

@ornicar ornicar closed this as completed Nov 23, 2024
@ornicar ornicar closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants