fix erroneous mouse motion when alt-tabbing in CS2 #11460
+32
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expikr
changed the title
expikr
changed the title
expikr
force-pushed
the
relative-warp
branch
2 times, most recently
from
d551025
to
8b12d09
Compare
expikr
force-pushed
the
relative-warp
branch
5 times, most recently
from
39ee4a1
to
8560cc7
Compare
The following changes do not alter any logic: - rename x/ydelta fields to x/y_accu to better reflect what it actually is about - coalesce the logic for modifying internal state to one spot, branch based on whether the input was a move or a warp The following changes alter the logic: - put the x/y_accu addition under the relative branch only, warps should not add to the accumulation buffer by any definition - (MAIN FIX) when the destination window desires relative mode, warp events should be dropped if SDL_MOUSE_RELATIVE_WARP_MOTION is false, or have x/yrel set to zero if true
expikr
force-pushed
the
relative-warp
branch
from
8560cc7
to
0451cf2
Compare
slouken
reviewed
Nov 14, 2024
slouken
reviewed
Nov 14, 2024
Co-authored-by: Sam Lantinga <[email protected]>
Yep, this fixes it in my game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11422
@Slartibarty can you verify if this fix works for your game?