New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecked return values #113

Open

guijan opened this issue Jun 25, 2024 · 0 comments

Contributor

guijan commented Jun 25, 2024

Return values are sometimes not checked in swanstation:

swanstation/src/common/byte_stream.cpp

Lines 564 to 565 in 7a27436

    
           m_pPrivateMemory = (u8*)std::malloc(new_size); 
        
           std::memcpy(m_pPrivateMemory, m_pMemory, m_iSize);

swanstation/src/common/event.cpp

Lines 84 to 88 in 7a27436

    
           Event::Event(bool auto_reset /* = false */) : m_auto_reset(auto_reset) 
        
           { 
        
             pthread_mutex_init(&m_mutex, nullptr); 
        
             pthread_cond_init(&m_cv, nullptr); 
        
           }

There are other unchecked uses of these functions, and likely others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment