Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad quality of handheld border images #661

Closed
mtmrc opened this issue Dec 18, 2024 · 4 comments
Closed

Bad quality of handheld border images #661

mtmrc opened this issue Dec 18, 2024 · 4 comments

Comments

@mtmrc
Copy link

mtmrc commented Dec 18, 2024

It seems like borders got converted to lower bit depth which creates banding and dithering issues, especially in the upper right corner of viewport which simulates external lighting. Borders in glsl shaders don't have this issue.

@hizzlekizzle
Copy link
Collaborator

Yes, it's from "optimizing" them. The glsl versions are ~3x the filesize, and we've had complaints from downstream projects that use our shaders about the size of the repo, which is mostly big png images.

@mtmrc
Copy link
Author

mtmrc commented Dec 19, 2024

I see. Well it's easy to "fix" by pointing the shader to old images, but wouldn't it be better to just delete that effect from viewport since it's so degraded, or are people just not bothered by that.

@hizzlekizzle
Copy link
Collaborator

Dunno. I guess nobody's noticed. They've been like that for 10 months 🤷

There are some higher quality, higher resolution versions available on the libretro forums with and without the glare effect, if you're interested in replacing them locally.

@mtmrc
Copy link
Author

mtmrc commented Dec 20, 2024

Yeah, I already did. It seems it's more pronounced when a game has black backgrounds, so on a lot of games it's not as noticable. Anyway since it's done for file size reasons and majority doesn't seem to mind I guess it's not an issue.

@mtmrc mtmrc closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants