Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emulator corr indexing #657

Open
wants to merge 6 commits into
base: v0.58.0-release
Choose a base branch
from

Commits on Oct 18, 2017

  1. Fix emulator correlation strength indexing bug

    We were assuming only one basis vector when indexing the emulator
    correlation strength.
    dmcdougall committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    cda033f View commit details
    Browse the repository at this point in the history
  2. Fix discrepancy correlation param indexing

    This relied on the correct calculation of how many emulator correlation
    strength parameters there were; we had assumed there was one svd term.
    dmcdougall committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    68aac28 View commit details
    Browse the repository at this point in the history
  3. Fix indexing error in dimSum variable

    Again, this relied on the calculation of the number of emulator
    correlation strength parameters.  We had assumed there was one svd basis
    vector which is an incorrect assumption.
    dmcdougall committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    8d5ab22 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2017

  1. Fix emulator data precision indexing

    There are num_svd_terms of these things, not 1.
    dmcdougall committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    5eff358 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83f9393 View commit details
    Browse the repository at this point in the history
  3. Fix emulator correlation strength indexing

    We were underestimating how many of these variables there were.  There
    aren't always dimScenario+dimParameter.  There's
    dimScenario+dimParameter *for each* emulator precision variable.
    dmcdougall committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    40d390f View commit details
    Browse the repository at this point in the history