Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftarget is missing from the C interface #61

Closed
zaikunzhang opened this issue Sep 15, 2023 · 1 comment
Closed

ftarget is missing from the C interface #61

zaikunzhang opened this issue Sep 15, 2023 · 1 comment
Assignees
Labels
c Issues related to the C interface or implementation python Issues related to the Python interface or implementation

Comments

@zaikunzhang
Copy link
Member

zaikunzhang commented Sep 15, 2023

Hi @jschueller ,

ftarget is an essential input from the user. I think it will be good to include it in the C interface.

If the user does not want to / cannot specify ftarget, then he/she should input -INFINITY, where INFINITY is the micro in math.h for representing infinity. I hope my understanding is correct and I hope INFINITY is standard C. It is a pity that C does not support optional arguments.

This was related to a previous comment from Tom on the Python interface, where the same comment applies, and we can default ftarget to $-\infty$ if there is no input from the user.

Thank you.

Zaikun

@zaikunzhang zaikunzhang added the c Issues related to the C interface or implementation label Sep 15, 2023
@zaikunzhang zaikunzhang added the python Issues related to the Python interface or implementation label Sep 15, 2023
@zaikunzhang
Copy link
Member Author

Closed by #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Issues related to the C interface or implementation python Issues related to the Python interface or implementation
Projects
None yet
Development

No branches or pull requests

2 participants