Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: incorrect instructions to run js-libp2p #283

Closed
marten-seemann opened this issue Aug 28, 2023 · 3 comments
Closed

interop: incorrect instructions to run js-libp2p #283

marten-seemann opened this issue Aug 28, 2023 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

The README claims that js-libp2p can be run using: npm run test -- -t node.
That doesn't work:

npm ERR! Lifecycle script `test` failed with error:
npm ERR! Error: Missing script: "test"

To see a list of scripts, run:
  npm run
npm ERR!   in workspace: [email protected]
npm ERR!   at location: /Users/marten/src/go/src/github.com/libp2p/js-libp2p/interop
npm ERR! Missing script: test

npm ERR! A complete log of this run can be found in: /Users/marten/.npm/_logs/2023-08-28T05_04_05_748Z-debug-0.log

Looking at the ENTRYPOINT of the Dockerfile, this should probably be test:interop:multidim, but I'm not sure which command line flags would be needed.

@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Aug 28, 2023
@marten-seemann
Copy link
Contributor Author

Running with test:interop:multidim fails for different reasons then. I opened libp2p/js-libp2p#1994.

@MarcoPolo
Copy link
Contributor

The whole section for Running locally needs to be reworded. It is more like debugging locally

@MarcoPolo MarcoPolo removed their assignment Aug 28, 2023
@MarcoPolo
Copy link
Contributor

I'm going to close this issue in favor of #282 because they are the same issue. npm run test -- -t node is meant to be run within the js test-plans implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants