Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Firefox WebRTC test #2642

Open
achingbrain opened this issue Jul 30, 2024 · 2 comments
Open

Flaky Firefox WebRTC test #2642

achingbrain opened this issue Jul 30, 2024 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@achingbrain
Copy link
Member

achingbrain commented Jul 30, 2024

Sometimes the receiving end of the can send a large file WebRTC test doesn't receive all of the bytes when running in Firefox, Chrome is fine:

  1) basics
       can send a large file:

      expected Uint8Array[ 0, 0, 0, 0, 0, 0, 0, …(5242845) ] to equal Uint8Array[ 0, 0, 0, 0, 0, 0, 0, …(5242881) ]
      + expected - actual

This fails in CI quite often and can be reproduced locally too.

It seems to happen when there are several datachannels open on the connection simultaneously so may be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1902850 - the fix for this should ship in Firefox 129 on August 6th, though we need to wait for that version of FF to be included in playwright to verify the fix.

@achingbrain achingbrain added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels Jul 30, 2024
@achingbrain
Copy link
Member Author

achingbrain commented Jul 30, 2024

It seems to happen when there are several datachannels open on the connection simultaneously

I don't think this is the case, it still happens if I add a delay in the test to ensure there are no other streams open.

Investigation continues.

@SgtPooki
Copy link
Member

SgtPooki commented Aug 13, 2024

looks like playwright has the latest Firefox set, but hasn't released an updated version to NPM yet: microsoft/playwright@5cc1e7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants