This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: use @noble/hashes instead of node-forge for keys #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2022-09-13 conversation: we'd prioritize this if it would actually let us get rid of node-forge. If we were to merge it now the bundle size would increase. |
I have just checked and the PR actually throws node-forge out. It is not included. Can you explain what you mean by bundle size increase? |
|
@paulmillr in that one file, but not out of the entire package, i believe https://github.com/search?q=repo%3Alibp2p%2Fjs-libp2p-crypto%20node-forge&type=code |
|
@ljharb ah, thought the pr is complete. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use @noble/hashes instead of node-forge for keys
Fixes #205