From b7d79b071f4c8ceb44b9cbbceb564eedc9b97404 Mon Sep 17 00:00:00 2001
From: sukun <sukunrt@gmail.com>
Date: Tue, 20 Aug 2024 22:41:31 +0530
Subject: [PATCH] test fix for go1.23

---
 p2p/net/nat/nat.go      | 1 +
 p2p/net/nat/nat_test.go | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/p2p/net/nat/nat.go b/p2p/net/nat/nat.go
index 28ffd4a5b2..787842ff70 100644
--- a/p2p/net/nat/nat.go
+++ b/p2p/net/nat/nat.go
@@ -43,6 +43,7 @@ func DiscoverNAT(ctx context.Context) (*NAT, error) {
 	extIP, err := natInstance.GetExternalAddress()
 	if err == nil {
 		extAddr, _ = netip.AddrFromSlice(extIP)
+		fmt.Println(extAddr)
 	}
 
 	// Log the device addr.
diff --git a/p2p/net/nat/nat_test.go b/p2p/net/nat/nat_test.go
index 50e1eb3a23..904089b91a 100644
--- a/p2p/net/nat/nat_test.go
+++ b/p2p/net/nat/nat_test.go
@@ -45,7 +45,9 @@ func TestAddMapping(t *testing.T) {
 	require.False(t, found, "didn't expect a port mapping for unmapped protocol")
 	mapped, found := nat.GetMapping("tcp", 10000)
 	require.True(t, found, "expected port mapping")
-	require.Equal(t, netip.AddrPortFrom(netip.AddrFrom4([4]byte{1, 2, 3, 4}), 1234), mapped)
+	// go1.23 change: https://github.com/golang/go/issues/68113
+	addr, _ := netip.AddrFromSlice(net.IPv4(1, 2, 3, 4))
+	require.Equal(t, netip.AddrPortFrom(addr, 1234), mapped)
 }
 
 func TestRemoveMapping(t *testing.T) {