Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide for libp2p node monitoring #158

Closed
Tracked by #1711
BigLep opened this issue Jun 28, 2022 · 5 comments
Closed
Tracked by #1711

Guide for libp2p node monitoring #158

BigLep opened this issue Jun 28, 2022 · 5 comments
Assignees

Comments

@BigLep
Copy link
Contributor

BigLep commented Jun 28, 2022

Done Criteria

There is a easily discoverable way for a libp2p node operator to find the monitoring options available to them for the libp2p implementation they are using (e.g., new docs section/page at https://docs.libp2p.io/monitoring).

Why Important

libp2p implementations have various ways to view node health. This information is usually buried within language-specific docs, which can be harder to discover.

Notes

This page is expected to be minimal, mostly providing links to the relevant documentation for specific implementations for things like "how to enable Granafa dashboards".

There should likely be some linking from the docs generated from #153 as well.

@mxinden
Copy link
Member

mxinden commented Jul 1, 2022

The rust-libp2p metrics module with an example as well as a Grafana dashboard can be found here:

https://github.com/libp2p/rust-libp2p/tree/master/misc/metrics

@BigLep
Copy link
Contributor Author

BigLep commented Jul 23, 2022

@mxinden : are you suggesting our new docs page should link to https://github.com/libp2p/rust-libp2p/tree/master/misc/metrics ?

I think it's great that it shows what an example dashboard can look like by linking to https://kademlia-exporter.max-inden.de/d/Pfr0Fj6Mk/rust-libp2p . Other questions/observations though:

  1. Is it clear for users how they turn this on themselves?
  2. Do we also want to link to https://docs.rs/libp2p/0.46.1/libp2p/metrics/index.html ?
  3. https://docs.rs/libp2p/0.46.1/libp2p/metrics/index.html doesn't surface the example dashboard
  4. https://docs.rs/libp2p/0.46.1/libp2p/metrics/index.html references an "examples" directory, but doesn't link to it.

@mxinden
Copy link
Member

mxinden commented Jul 26, 2022

are you suggesting our new docs page should link to https://github.com/libp2p/rust-libp2p/tree/master/misc/metrics ?

Yes. It links to the dashboard and the examples directory.

Is it clear for users how they turn this on themselves?

That is my intuition, given that there is an examples directory.

Do we also want to link to https://docs.rs/libp2p/0.46.1/libp2p/metrics/index.html ?

I am fine with it, though I am not sure how much help the docs are.

https://docs.rs/libp2p/0.46.1/libp2p/metrics/index.html references an "examples" directory, but doesn't link to it.

It is a convention to have an examples directory at the root of the crate (aka package), thus Rust users will know where to find it.

@BigLep
Copy link
Contributor Author

BigLep commented Aug 7, 2022

This is being handled in #160

@p-shahi
Copy link
Member

p-shahi commented Aug 26, 2022

Parts related to resource mgmt are addressed in https://docs.libp2p.io/reference/dos-mitigation/#monitoring-your-application

We have a metrics effort in go-libp2p started, we can include this as a part of that. Therefore closing in favor of libp2p/go-libp2p#1356

@p-shahi p-shahi closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants