-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editor config #79
Comments
Style suggestions:
|
I prefer line break after sentence (easier to track changes). Maybe editor config doesn't handle this properly? |
That sounds reasonable to me. (I do my line-breaks in Markdown manually anyway.) If we break after each sentence, maybe suggest no hanging white-space? |
I typed this earlier but then forgot to comment: I've not really thought about this but perhaps we could have CI:
It might make leaving comments on diffs a little more awkward but it would avoid requiring people to configure editors. |
I like that idea as it's basically impossible to enforce style-guides. And it's no more awkward than looking through commits that contain style-updates. |
I like the idea a lot! |
With lots of contributors having strong opinions on their text configuration, we should include a style guide and/or editor config file that defines how we format the lessons. This is partly to circumvent the need for style debates, and also to reduce the number of re-formatting changes made in PRs, which clutter the diff.
The text was updated successfully, but these errors were encountered: