Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate duplication between top-level and v4 directory #35

Open
aarongable opened this issue Jun 30, 2023 · 0 comments · May be fixed by #39
Open

Eliminate duplication between top-level and v4 directory #35

aarongable opened this issue Jun 30, 2023 · 0 comments · May be fixed by #39

Comments

@aarongable
Copy link

We have a lot of duplicate code between the repo root and the v4 sub-directory. This was originally a compatibility thing, to allow this repo to be used either in module mode or not. But now everything should just be module mode, and the two versions have diverged, so we should eliminate the duplicate code and simplify the repo structure.
mcpherrinm added a commit to mcpherrinm/pkcs11key that referenced this issue Dec 31, 2024
@mcpherrinm
Remove v2 code
57246ae 
pkcs11key has switched to the module-enabled v4 a long time ago.  The v2 code
at the top level should be removed.

We cannot tag any more v2 releases after this, but we aren't planning to.

Fixes letsencrypt#35
@mcpherrinm mcpherrinm linked a pull request Dec 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove v2 code mcpherrinm/pkcs11key
1 participant
@aarongable