Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Rather than store artifacts in the accepted_roots dir, upload them to Github as a Release #3

Open
jcjones opened this issue Aug 11, 2022 · 0 comments
Open

[Improvement] Rather than store artifacts in the accepted_roots dir, upload them to Github as a Release #3

jcjones opened this issue Aug 11, 2022 · 0 comments
Assignees
@jcjones @pgporada @aarongable

Comments

@jcjones
Copy link
Contributor

jcjones commented Aug 11, 2022

Bug Report

It's generally a good idea to not put final artifacts into a Git repo, but I am approving PR #1 as-is, as it has all the bones we want.

In the future, we should rework the scripts to write the final output to a tempdir, tar it up, and use a CLI tool (like the Github one) to submit the tarball as a release artifact. It could even be done by a Github action.

Then the far end of the k8s tooling should look for those releases instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcjones jcjones

@pgporada pgporada

@aarongable aarongable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcjones @pgporada @aarongable