Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the cleanup_queue array #9

Open
letorbi opened this issue Feb 25, 2020 · 1 comment
Open

Get rid of the cleanup_queue array #9

letorbi opened this issue Feb 25, 2020 · 1 comment
Labels
Improvement Make existing code better

Comments

@letorbi
Copy link
Owner

letorbi commented Feb 25, 2020

The cleanup_queue array is a really ugly solution and should be avoided.

By adding the info-entry of watch to all its event we could get rid of the cleanup-queue, because the only reason to have it, that we still need the entries in the self.__info dictionary in case get_path() is called. If the info is part of the event, get_path() could get all required information from the event instead of from self.__info.

@letorbi letorbi added enhancement New feature or request Improvement Make existing code better and removed enhancement New feature or request labels Feb 25, 2020
@letorbi
Copy link
Owner Author

letorbi commented Feb 26, 2020

The proposed solution might also require that the info.children dictionary contains real references to the related self.__info entries. Otherwise the garbage collector might clean-up stuff too early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Make existing code better
Projects
None yet
Development

No branches or pull requests

1 participant