Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing of filter #3

Closed
letorbi opened this issue Oct 2, 2019 · 1 comment
Closed

Allow changing of filter #3

letorbi opened this issue Oct 2, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@letorbi
Copy link
Owner

letorbi commented Oct 2, 2019

The value for filter should be changeable. If the filter changes the watched subdirectories should also be updated.

Requires #1
@letorbi letorbi added the enhancement New feature or request label Oct 2, 2019
@letorbi letorbi mentioned this issue Oct 2, 2019
Closed
@letorbi
Copy link
Owner Author

letorbi commented Feb 25, 2020

This could also be done by removing and re-adding a recursive watch. Since a filter change also requires to walk the whole subtree, removing and re-adding would only be slightly faster. This slight performance improvement does not justify the extra coding effort, so I'm closing this issue.

Please re-open the issue, if you think that you really need this feature.

@letorbi letorbi closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@letorbi