Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClose hook hangs indefinitely #107

Open
giovanni-bertoncelli opened this issue Nov 15, 2023 · 0 comments
Open

onClose hook hangs indefinitely #107

giovanni-bertoncelli opened this issue Nov 15, 2023 · 0 comments

Comments

@giovanni-bertoncelli
Copy link

Hi,
I'm reporting a bug (that took nearly 2 years to be found..). It seems that onClose hook of this plugin is not implemented correctly since close() function on nodemailer transport does not expect any callback, you can see that clearly on this row: https://github.com/nodemailer/nodemailer/blob/master/lib/smtp-transport/index.js#L407. This results in the fastify process to hang indefinitely without any chance to terminate anytime. I can make a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant