Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a service for changing window URL #21

Open
leonardochaia opened this issue Aug 16, 2019 · 0 comments
Open

Use a service for changing window URL #21

leonardochaia opened this issue Aug 16, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@leonardochaia
Copy link
Owner

Create a service responsible of changing the window's URL and use that instead of accessing window.location.href directly; for better testing and implementation changes.
@leonardochaia leonardochaia added the good first issue Good for newcomers label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leonardochaia