Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness test doesn't fail when rest service is not running #7

Open
t-d-d opened this issue Mar 12, 2018 · 1 comment
Open

Liveness test doesn't fail when rest service is not running #7

t-d-d opened this issue Mar 12, 2018 · 1 comment

Comments

@t-d-d
Copy link

t-d-d commented Mar 12, 2018

The liveness probe is not always failing when it should, specifically when the service seems to be totally down. I think below line should also check for the curl command having failed, e.g. add || [ $? != 0 ]

https://github.com/Landoop/dockers/blob/93f36ff9fb9fcac64fa1038f1cfa48effbcdc7bd/kafka-connect/liveliness.sh#L18

(Also, currently line 24 and 33 syntax error in this case, which doesn't cause a probe failure. Should really be using [[ ]] ?)

@andrewstevenson
Copy link
Contributor

@t-d-d thanks. We will be revamping the images soon. Do you mind submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants