Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images uploaded to theme settings with spaces don't display on the front-end #39

Open
ghost opened this issue Nov 23, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 23, 2018

Images with spaces in their filenames that are uploaded for banner images, etc. in the Frescobox theme settings don't display correctly on the front-end.

Context

Identified by a trial user who had uploaded images that weren't displaying:

https://app.intercom.io/a/apps/7236196445273cea007287c0c90a2f0d598567cc/inbox/inbox/194039/conversations/19661194725

Expected Behavior

If files uploaded to theme settings have spaces or other nonconformant characters, they should be encoded to prevent display/reference issues.

@ghost ghost added the bug Something isn't working label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants