Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA fixes #7

Open
1 of 19 tasks
dhalarewich opened this issue Apr 6, 2017 · 0 comments
Open
1 of 19 tasks

QA fixes #7

dhalarewich opened this issue Apr 6, 2017 · 0 comments

Comments

@dhalarewich
Copy link
Contributor

dhalarewich commented Apr 6, 2017

  • Related products (cross-sells and up-sells) aren't shown on product page if any are added to the product

  • product attributes are shown twice. Top one should be removed (see screenshot)

  • product page: There's no space above the QTY field label when there's product extras

  • product page: Extra checkbox should be on the left

  • product page: Bulk pricing table headings should be bold

golden_egg

  • Logo theme customization setting needs a caption that specifies max width or height, and this should be specified in the CSS. Uploading a large image breaks the header.

home

  • Blog page doesn't appear to list any categories, or show any blog posts.

  • Global: base Color should default to the actual default color (#34a99)

theme_settings

instead of being blank.
  • "What's New" should show newest 8 products, instead of pulling from a collection

home

  • Homepage hero banner should be a theme customization setting (and be listed right after the favicon image in the YAML). Right now it's hardcoded into the home page template: <img class="lazy" src="{{ 'images/homepage-3-banner.jpg'|theme_resource }}">

  • Header nav widget block includes a bunch of code, which isn't user friendly and renders weird in the WYSIWYG box. Home and Shop + dropdown can be hardcoded, and the rest can be a widget block (but remove the My Orders and My Profile Twig logic and links)

screenshot 2017-04-06 16 37 49

  • Add My Profile and My Orders links into layout-header partial:
Welcome, {{ customer.first_name }}!
<a href="{{ site_url('profile') }}">Profile</a> |
<a href="{{ site_url('orders') }}">Orders</a> |
<a href="{{ site_url('logout') }}">Logout</a>
{% else %}
  • Split out footer-menu widget block so there's no Twig logic in it. Contact info can be it's own widget block, Shop - make this hard coded, My Account - make this hard coded, Our Support - make this a new widget block.

  • For social link URL theme setting fields: if they're blank (there should be no default value), don't show the icon. You should be able to do something like:

{% if theme.facebookURL %}
<a href="{{ theme.facebookURL }}</a>
{% endif %}
  • Make the newsletter section on homepage on/off using a theme setting checkbox. Turn it off by default.

home

  • Make the phone number in header a theme setting text field

golden_egg

  • Contact form on Contact page has broken alignment.

contact

  • Make the content on Contact page easier to edit: Remove the 3 columns of locations, and make the move the main page content into a widget block.

  • Checkboxes on checkout pages (and possibly elsewhere in theme) use a color fill, but no X or checkmark, which is bad UX. Let's add a tick or X to them.

checkout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant