Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration files do not register modified values #64

Open
jiive opened this issue Jan 13, 2023 · 4 comments
Open

Configuration files do not register modified values #64

jiive opened this issue Jan 13, 2023 · 4 comments

Comments

@jiive
Copy link

jiive commented Jan 13, 2023

Version info
Java version: 1.16.5
Minecraft Forge version: 36.2.39

Describe the bug
I am attempting to buff the base damage of the Plasma Cannon from 2 to 4. Despite making these value changes within the configuration files themselves and even saving these modifications to the defaultconfigs folder, these changes simply don't apply themselves. I went as far as creating a clean profile in Overwolf and only installed this mod along with Numina. Same results, and modified values don't seem to apply.

To Reproduce
Steps to reproduce the behavior:

  1. Download this mod and Numina.
  2. Go to [instance]/saves/[save]/serverconfig/powersuits-server.toml
  3. Modify powersuits-server.toml and save any changes.
  4. Boot up Minecraft Forge and load any save with the modified powersuits-server.toml.
  5. Observe as absolutely nothing changes despite configuration files being modified.

Expected behavior
In spite of any changes to powersuits-server.toml, all values seem to remain on default.

Mod list
configured-1.5.3-1.16.5
Hwyla-forge-1.10.11-B78_1.16.2
jei-1.16.5-7.7.1.153
ModularPowersuits-1.16.5-2.2.31
Numina-1.16.5-2.2.31
Pehkui-3.6.3+1.16.5-forge

Log files
latest.log

@jiive
Copy link
Author

jiive commented Jan 14, 2023

Also, as a request for the configuration files, is it possible if the mod author can add a configurable charge speed for both the Plasma Cannon and the Railgun? Thanks in advance!

@Omegatron9
Copy link

I had the same issue trying to change the armour values of the platings and energy shields.

@lehjr
Copy link
Owner

lehjr commented Feb 18, 2023

I'll have to look into the config system probably this week. I stopped porting beyond 1.16.5 for now so I can work on some issues instead of dragging them along to a new MC version. So there will probably be a couple more 1.16.5 releases before I move on to another version. Next release will have GUI changes. After that will be simplifying some of the settings and translation files, also digging into the config system to fix some things.

@lehjr
Copy link
Owner

lehjr commented Feb 19, 2023

Turns out the fix for that issue was relatively simple, and will be fixed in the next release. However, the server side config file will be replaced due to the issue that was plaguing the whole setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants