Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] CMAKE_OSX_DEPLOYMENT_TARGET not CACHE #191

Closed
st751228051 opened this issue Nov 16, 2023 · 2 comments
Closed

[bug] CMAKE_OSX_DEPLOYMENT_TARGET not CACHE #191

st751228051 opened this issue Nov 16, 2023 · 2 comments
Assignees
Labels

Comments

@st751228051
Copy link

st751228051 commented Nov 16, 2023

Describe the bug
ios-cmake-4.4.1, build with "-DPLATFORM=MAC -DARCHS=x86_64", top display 10.13, but actualy -target x86_64-apple-macos13.3.

To Reproduce
Steps to reproduce the behavior:

  1. ios-cmake-4.4.1
  2. build with "-DPLATFORM=MAC -DARCHS=x86_64"
  3. top display "-- Autoconf target triple: x86_64-apple-macosx10.13
    -- Using minimum deployment version: 10.13 (SDK version: 13.3)",
    but bottom actualy "-target x86_64-apple-macos13.3".

Expected behavior
-target x86_64-apple-macos10.13

Environment

  • What version of CMake did you run? 3.27.7
  • Your faulty CMakeLists.txt here: no
--- Paste here ---

Clue:
https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_DEPLOYMENT_TARGET.html#variable:CMAKE_OSX_DEPLOYMENT_TARGET
This variable should be set as a CACHE entry (or else CMake may remove it while initializing a cache entry of the same name) unless policy CMP0126 is set to NEW.

I change ios.toolchain.cmake Line:829 "set(CMAKE_OSX_DEPLOYMENT_TARGET ${DEPLOYMENT_TARGET})" to "set(CMAKE_OSX_DEPLOYMENT_TARGET ${DEPLOYMENT_TARGET} CACHE STRING "Minimum OS X deployment version")",
then it became ok!

@leetal
Copy link
Owner

leetal commented Nov 16, 2023

I have now begun adding a test-patch to see if i break anything by caching some variables. Please see #192 if you want to test locally as well :)

@leetal
Copy link
Owner

leetal commented Nov 16, 2023

Fixed in #192

@leetal leetal closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants