Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not fire an error when username or token are missing #9

Open
ekryski opened this issue Mar 25, 2015 · 0 comments
Open

Should not fire an error when username or token are missing #9

ekryski opened this issue Mar 25, 2015 · 0 comments

Comments

@ekryski
Copy link

ekryski commented Mar 25, 2015

I think this should also be left up to the user for how they want to handle this. For example, if I only want to use a token and my app doesn't require a username I shouldn't be forced to provide one. I realize that it is more secure to use username and token but IMO this library shouldn't enforce that.

Currently, I have to hack things and tack on req.body.username = true in order for things to work when I don't want to pass a username. Less is more 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant