You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off. Thanks for writing the module! Much appreciated.
I'm going to issue a PR to remove the call of toLowerCase() on these lines. This actually bit me and I spent quite a bit of time trying to figure out what went wrong. I don't think it should be the responsibility of passport-token to make the strings lowercase. I think that concern should be left up to the person implementing.
The text was updated successfully, but these errors were encountered:
ekryski
added a commit
to ekryski/passport-token
that referenced
this issue
Mar 25, 2015
Hi. Sorry, this module was written really very quickly for a personal project (that never even made it to production). After that I kind of forgot about it - and never really thought anyone would use it!
I'll try to do a review in the next couple of days and get your changes in.
First off. Thanks for writing the module! Much appreciated.
I'm going to issue a PR to remove the call of
toLowerCase()
on these lines. This actually bit me and I spent quite a bit of time trying to figure out what went wrong. I don't think it should be the responsibility of passport-token to make the strings lowercase. I think that concern should be left up to the person implementing.The text was updated successfully, but these errors were encountered: